#178 alb url double encoding#184
Merged
jordaneremieff merged 1 commit intoKludex:mainfrom Apr 20, 2021
Merged
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this closes issue #178. See the issue for a discussion of the bug. Tests pass, and I have tested this on a lambda function being served by an ALB.
In short: "If the query parameters are URL-encoded, the load balancer does not decode them. You must decode them in your Lambda function."
https://docs.aws.amazon.com/elasticloadbalancing/latest/application/lambda-functions.html
Thanks to @jurasofish for initially finding the issue and writing the failing test. This PR includes his commit from #179, which can be closed if this PR is merged.
I don't know if something similar needs to be applied to the other handlers, not as familiar / not using those trigger methods.
Minor mishap with GitHub which is why #183 got closed... my bad.